Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Unit test Etherman #28

Merged
merged 15 commits into from
Dec 15, 2023
Merged

Unit test Etherman #28

merged 15 commits into from
Dec 15, 2023

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Dec 13, 2023

No description provided.

@nivida nivida marked this pull request as ready for review December 13, 2023 15:07
@Stefan-Ethernal
Copy link
Contributor

Seems like we would need to exclude mocks folder from SonarCloud coverage 🙂

Copy link
Contributor

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but leaving some minor suggestions here and there to consider.

cmd/main.go Outdated Show resolved Hide resolved
etherman/etherman_test.go Outdated Show resolved Hide resolved
etherman/etherman_test.go Show resolved Hide resolved
etherman/etherman_test.go Outdated Show resolved Hide resolved
etherman/etherman_test.go Show resolved Hide resolved
etherman/etherman_test.go Show resolved Hide resolved
etherman/etherman_test.go Show resolved Hide resolved
etherman/etherman_test.go Outdated Show resolved Hide resolved
etherman/etherman_test.go Outdated Show resolved Hide resolved
etherman/etherman_test.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Dec 14, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@nivida nivida merged commit dc84ba1 into main Dec 15, 2023
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants